Repository navigation
feat(bench): answer bench harness and the 5-filing pilot - #77
Merged
Merged
Conversation
navbench -answer runs the one generative step after navigation: the engine's synthesiseAnswer prompt over the evidence pages, on an OpenAI-compatible endpoint (GLM-4.6 on z.ai by default) with thinking off. It calls the endpoint directly because llmgate cannot yet turn a reasoning model's thinking off (HAL-1741). Answers, gold answers and answer timing and tokens land in the per-question JSONL for grading. tocdump reports parse_seconds beside seconds. The TOC stage was being timed from after the PDF was read, and on five 10-Ks parsing took 7-17 s, as long as the stage itself (HAL-1742). First use, 5 filings and 30 FinanceBench questions: 27/30 correct under Mafin 2.5's grading prompt, median 10.4 s from question to answer.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's GuideExtends navbench with an optional, configurable grounded-answer generation step over retrieved pages and records answer metrics alongside retrieval results; also adds head-skim configuration and PDF parse-time telemetry. Sequence diagram for the navbench grounded-answer evaluationsequenceDiagram
participant CLI as navbench
participant Nav as JudgeNavigator
participant API as OpenAICompatibleAPI
participant Output as ResultsJSONL
CLI->>Nav: retrieval.JudgeNavigator.Search
Nav-->>CLI: res.Evidence
CLI->>API: POST /chat/completions
API-->>CLI: answer text and usage
CLI->>Output: write answer, gold answer, and answer metrics
Flow diagram for navbench answer and telemetry optionsflowchart TD
Start[Run navbench] --> Configure[Configure head skim and page limits]
Configure --> Retrieve[Retrieve and rank evidence pages]
Retrieve --> AnswerEnabled{answer flag enabled?}
AnswerEnabled -- No --> Record[Record retrieval result]
AnswerEnabled -- Yes --> Prompt[Build grounded prompt from evidence pages]
Prompt --> Generate[Generate one answer with configured model]
Generate --> RecordAnswer[Record answer, gold answer, tokens, and latency]
RecordAnswer --> Record
Record --> End[Write JSONL output]
Parse[Parse PDF pages] --> ParseTime[Record parse_seconds]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
hallelx2
changed the base branch from
halleluyaholudele/hal-1566-judgewalk-skim-every-page-so-head-skim-and-section-ranking
to
main
October 11, 2026 22:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The answer-accuracy harness that sits between the head-skim work (#71) and pincites (#72) in this stack. It grades answers with PageIndex/Mafin's own grading prompt; the pilot over 5 filings and 30 questions graded 27 correct.
Verified on Lorx CI at the stack's tip (vectorless-engine run #3: fmt, vet, build, golangci-lint, test all green). GitHub Actions cannot start jobs on this account (HAL-1712).
Closes HAL-2705
Summary by Sourcery
Add answer generation and richer performance instrumentation to the navigation benchmark harness.
New Features:
Enhancements: