Scenario discovery fix + plotting/CLI improvements + changes in readme.md - #12
Open
Comp-era wants to merge 4 commits into
Open
Scenario discovery fix + plotting/CLI improvements + changes in readme.md #12Comp-era wants to merge 4 commits into
Comp-era wants to merge 4 commits into
Conversation
…; rename script to lowercase Rename AnalyseBenchmarkResults.py -> analysebenchmarkresults.py. Accept a run1/ directory (default mode) or run1_analysis.tgz (-a mode) in scenario discovery so non-archive benchmarks are no longer rejected with 'no scenario directories found'. Build the melquiplot legend from get_reverse_bool(): distance metrics (irmsd/ilrmsd) keep 'lo <= M < hi' in Angstrom; dockq is unitless and higher-is-better, so it now reads 'lo < M <= hi' without the unit.
The script was renamed to lowercase (analysebenchmarkresults.py) but analyse.sh, README.md, analysis/README.md, and CONTRIBUTING.md still pointed at the old capitalized name, which would break on case-sensitive filesystems.
Reflects the scenario-outer/PDBid-inner layout, type-aware default metric, auto-detected caprieval stage names, new -l/--label and --per-scenario-plots flags, and violin/melquiplots being opt-in.
Comp-era
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
run1_analysis.tgz archive (-a mode), so non-archive benchmarks are no longer
rejected with "no scenario directories found".
(irmsd/ilrmsd) keep "lo <= M < hi" in Angstrom; dockq is unitless and
higher-is-better, so it now reads "lo < M <= hi" without the unit.
Plot tweaks