Skip to content

Update writeforall project profile 8751 - #8872

Closed
brianf4 wants to merge 3 commits into
hackforla:gh-pagesfrom
brianf4:update-writeforall-8751
Closed

brianf4 wants to merge 3 commits into
hackforla:gh-pagesfrom
brianf4:update-writeforall-8751

Conversation

@brianf4

@brianf4 brianf4 commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Fixes #8751

What changes did you make?

  • Updated description
  • Updated project status from: "status: On Hold" to "status: Closed"
  • Updated visible from: "visible: true" to "visible: false"
  • All updates were on writeforall.md

Why did you make the changes (we will use this info to test)?

  • To update the project description, status, and visibility of the Write for All project.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied before-update before-update1
Visuals after changes are applied after-update after-update1

@github-actions

Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b brianf4-update-writeforall-8751 gh-pages
git pull https://github.com/brianf4/website.git update-writeforall-8751

@github-actions github-actions Bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue epic size: 0.25pt Can be done in 0.5 to 1.5 hours Issue Making: Level 1 Make issues from a template and a spreadsheet Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level labels Nov 12, 2026
@yepezjuan
yepezjuan self-requested a review November 12, 2026 22:13
@yepezjuan

Copy link
Copy Markdown
Member

ETA: 11/13/26
Availability: 6-7pm

@MStoutTech

Copy link
Copy Markdown
Member

Review ETA: End of Day 11/13/26
Availability: 4-8 PM Friday

@KyleA99

KyleA99 commented Nov 13, 2026

Copy link
Copy Markdown
Member

ETA: 11/14/26
Availability: 1-7pm

@yepezjuan yepezjuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Brian, changes seem to reflect all of the requirements of the issue. You built the PR correctly with required format. Thank you for helping out with this issue.

@MStoutTech

Copy link
Copy Markdown
Member

Hi @brianf4

Just looking at the linked #8751 issue, I noticed both that one and this PR request have the "Issue Making level 1" label and was wondering, was this supposed to be making an issue and not making the actual changes?

This section from the issue is why I am asking:
instructions

Thanks!

@brianf4

brianf4 commented Nov 14, 2026

Copy link
Copy Markdown
Member Author

Hi @MStoutTech!

I noticed both that one and this PR request have the "Issue Making level 1" label and was wondering, was this supposed to be making an issue and not making the actual changes?

Thats a good question.

The way I interpreted "Instructions for Website Team Leads After This Issue is Submitted" is once #8751 was created that there was additional instructions for for the website team leads. I'm not too familiar with the "Issue Making level 1" label but it did have the "front end" / "back end/devOps" label on which is why I decided to make the file changes in ‎_projects/writeforall.md‎.

Hopefully I'm not misinterpreting it. Maybe @kimberlyvaldez07 can shed some light on this? :)

@KyleA99

KyleA99 commented Nov 15, 2026

Copy link
Copy Markdown
Member

Hi @MStoutTech!

I noticed both that one and this PR request have the "Issue Making level 1" label and was wondering, was this supposed to be making an issue and not making the actual changes?

Thats a good question.

The way I interpreted "Instructions for Website Team Leads After This Issue is Submitted" is once #8751 was created that there was additional instructions for for the website team leads. I'm not too familiar with the "Issue Making level 1" label but it did have the "front end" / "back end/devOps" label on which is why I decided to make the file changes in ‎_projects/writeforall.md‎.

Hopefully I'm not misinterpreting it. Maybe @kimberlyvaldez07 can shed some light on this? :)

I think @MStoutTech is correct in her original comment, based off the "epic" and "Issue making: Level 1" tags on your MR and the corresponding issue.

Additionally, the issue linked in your MR, Issue #8751 appears to be very similar to Issue #8752, where a developer made the develop issue #8864 off of the corresponding Issue #8752.

The frontend/backend labels don't necessarily mean this is a developer issue as those tags are also added to epics/ERs that are created with the goal of created developer sub-issues of them.

I could be wrong, but leaning towards thinking @MStoutTech is correct in her comment. Tagging @yielderdev as he had some involvement with #8751 and is part of the merge team, so hopefully he can provide some insight.

@brianf4

brianf4 commented Nov 15, 2026

Copy link
Copy Markdown
Member Author

I see. Thank you @MStoutTech for catching this! You're correct.

After reading #7478 (comment) more thoroughly and comparing #8752 with #8864 I agree that it was meant to be turned into an issue rather than making the changes in the file directly.

And thank you @KyleA99 for the clarification!

@daras-cu

Copy link
Copy Markdown
Member

@brianf4 everyone is correct, the original issue #8751 was to create the issue to update the file, not actually make the changes. I'm going to close this PR, I'm assuming you were looking to work on a small issue so you will have to go back to the project board and find one from this column

@daras-cu daras-cu closed this Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Complexity: Small Take this type of issues after the successful merge of your second good first issue epic Issue Making: Level 1 Make issues from a template and a spreadsheet P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Write for All™

5 participants