Repository navigation
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: 11/13/26 |
|
Review ETA: End of Day 11/13/26 |
|
ETA: 11/14/26 |
yepezjuan
left a comment
There was a problem hiding this comment.
Great work Brian, changes seem to reflect all of the requirements of the issue. You built the PR correctly with required format. Thank you for helping out with this issue.
|
Hi @MStoutTech!
Thats a good question. The way I interpreted "Instructions for Website Team Leads After This Issue is Submitted" is once #8751 was created that there was additional instructions for for the website team leads. I'm not too familiar with the "Issue Making level 1" label but it did have the "front end" / "back end/devOps" label on which is why I decided to make the file changes in _projects/writeforall.md. Hopefully I'm not misinterpreting it. Maybe @kimberlyvaldez07 can shed some light on this? :) |
I think @MStoutTech is correct in her original comment, based off the "epic" and "Issue making: Level 1" tags on your MR and the corresponding issue. Additionally, the issue linked in your MR, Issue #8751 appears to be very similar to Issue #8752, where a developer made the develop issue #8864 off of the corresponding Issue #8752. The frontend/backend labels don't necessarily mean this is a developer issue as those tags are also added to epics/ERs that are created with the goal of created developer sub-issues of them. I could be wrong, but leaning towards thinking @MStoutTech is correct in her comment. Tagging @yielderdev as he had some involvement with #8751 and is part of the merge team, so hopefully he can provide some insight. |
|
I see. Thank you @MStoutTech for catching this! You're correct. After reading #7478 (comment) more thoroughly and comparing #8752 with #8864 I agree that it was meant to be turned into an issue rather than making the changes in the file directly. And thank you @KyleA99 for the clarification! |
|
@brianf4 everyone is correct, the original issue #8751 was to create the issue to update the file, not actually make the changes. I'm going to close this PR, I'm assuming you were looking to work on a small issue so you will have to go back to the project board and find one from this column |

Fixes #8751
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied