Skip to content

Added default permissions for lint-scss.yml file#8677

Open
sushma110396 wants to merge 1 commit into
hackforla:gh-pagesfrom
sushma110396:add-default-permissions-8583
Open

Added default permissions for lint-scss.yml file#8677
sushma110396 wants to merge 1 commit into
hackforla:gh-pagesfrom
sushma110396:add-default-permissions-8583

Conversation

@sushma110396
Copy link
Copy Markdown
Member

@sushma110396 sushma110396 commented Jun 2, 2026

Fixes #8583

What changes did you make?

  • Added minimum required permissions at the top level for lint-scss.yml file

Why did you make the changes (we will use this info to test)?

  • To ensure the workflow has only the permissions it needs
  • To minimise unnecessary privileges
  • To strengthen overall repository security

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes to the website. Please refer to the attached logs for reviewing the action output.

act-log.txt
act-pr-log.txt

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b sushma110396-add-default-permissions-8583 gh-pages
git pull https://github.com/sushma110396/website.git add-default-permissions-8583

@github-actions github-actions Bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 5pt Can be done in 19-30 hours labels Jun 2, 2026
@sushma110396
Copy link
Copy Markdown
Member Author

Local Workflow Testing
I tested the updated lint-scss.yml workflow locally using act after adding the permissions block.

Workflows/Events Tested
push event targeting gh-pages
pull_request event targeting gh-pages

Commands Used
act push -e push.json -j build
act pull_request -e pull_request.json -j build

Results
Lint SCSS workflow completed successfully for both events.

@castillios castillios self-requested a review June 3, 2026 00:03
@castillios
Copy link
Copy Markdown
Member

Review ETA: By Thurs 06/04 6PM
Availability: Weekdays before 8PM, Sat all day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 5pt Can be done in 19-30 hours

Projects

Status: PR Needs review

Development

Successfully merging this pull request may close these issues.

Specify default permissions for lint-scss.yml

2 participants