Repository navigation
Conversation
opening a case enabled a stored flipper actor per identity, which hit flipper's 100-actor cap and 500'd case creation (Flipper::Adapters::ActorLimit::LimitExceeded). the actor list was a hand-synced mirror of "identities with an open case", so membership is now the :has_open_verification_case group, computed from the cases table — nothing per-actor to enable, revoke, or leak. a data migration enables the group once and drops the stored actors.
Member
|
leo why is it a flipper flag at all lol
....just gate it to if they have an open vcase?
…On Sun, Oct 25, 2026, at 3:27 PM, Leo wrote:
@leowilkin <https://github.com/leowilkin> requested your review on: hackclub/auth#350 <#350> replace manual-verification flag actors with a computed flipper group.
—
Reply to this email directly, view it on GitHub <#350?email_source=notifications&email_token=BG7BAEB66LCYLARQ4NC6TZD5VZAYVA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGNBRHE4TKNJWGMZDDJTSMVQXG33OWBZGK5TJMV3V64TFOF2WK43UMVSKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#event-34199556321>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BG7BAEFWF6DYL26ZYJFBSQD5VZAYVAVCNFSNUABGKJSXA33TNF2G64TZHMYTANBZGI2DKOJQGI5US43TOVSTWNRQGI4DGMRVHEYTHILWAI>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/BG7BAED5WE44NYBTMIUQP2T5VZAYVA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGNBRHE4TKNJWGMZDDJTSMVQXG33OWBZGK5TJMV3V64TFOF2WK43UMVSKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android <https://github.com/notifications/mobile/android/BG7BAEBE2DTF2VKBWLOOKYL5VZAYVA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGNBRHE4TKNJWGMZDDJTSMVQXG33OWBZGK5TJMV3V64TFOF2WK43UMVSKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today!
You are receiving this because your review was requested.Message ID: ***@***.***>
|
per review: the flag was only ever a hand-synced mirror of "identity has an open case", so gate directly on that instead. the migration now removes the feature and its ~100 stored actors (which had hit flipper's 100-actor cap and 500'd case creation).
leowilkin
changed the title
Member
Author
|
mm.. not a flipper anymore |
Member
|
why is there even a migration?
.....or make a flip for the feature itself? claude, do you know what flipper is even for?
the feature itself sure, on individual users when we already have the vcase plumbing insane
leo, are you looking at what your claude is doing?
…On Sun, Oct 25, 2026, at 3:38 PM, Leo wrote:
*leowilkin* left a comment (hackclub/auth#350) <#350 (comment)>
done — flipper is out of the flow entirely. both call sites now gate on `verification_cases.open_cases.exists?` directly, the flag/actor plumbing is deleted, and the migration `Flipper.remove`s the feature (stored actors included). one trade to be aware of: no flipper kill switch for the flow anymore — turning it off means a deploy or withdrawing the open cases.
*🤖 Addressed by Claude Code <https://claude.com/claude-code>*
—
Reply to this email directly, view it on GitHub <#350?email_source=notifications&email_token=BG7BAEDRQN6TJG274XCBGCT5VZCEFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNBQGIZDIMRXHE2KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6402242794>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BG7BAEFAPO6ODP7PHBOYL5L5VZCEFAVCNFSNUABGKJSXA33TNF2G64TZHMYTANBZGI2DKOJQGI5US43TOVSTWNRQGI4DGMRVHEYTHILWAI>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/BG7BAECRJG5MF5RUU32RID35VZCEFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNBQGIZDIMRXHE2KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android <https://github.com/notifications/mobile/android/BG7BAEHHBRK3WVJ5MDJVGLT5VZCEFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNBQGIZDIMRXHE2KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because your review was requested.Message ID: ***@***.***>
|
per review: flipper state is ops data, not schema — the dead feature and its stored actors get deleted from the flipper UI instead.
Member
Author
|
we already gate the feature based on who we invite through the admin UI, so I don't think it needs a feature-wide flipper. and... yes the migration is gone. it was removing the flipper flag from the db, but I can do that myself, or.. just not do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what happened
opening a verification case 500'd in production with
Flipper::Adapters::ActorLimit::LimitExceeded: Actor limit of 100 exceeded for feature manual_verification_call_2026_07_03— flipper 1.3+ caps stored actors at 100 per feature because everyenabled?check loads the whole set.the fix
the flag was only ever a hand-synced mirror of "this identity has an open case": enabled on case open, revoked on approve/deny/withdraw, and checked right next to an open-case lookup at both call sites. so, per review, flipper is out of this flow entirely:
redirect_to_open_manual_caseandset_casegate directly onverification_cases.open_cases(one indexedexists?)enable_flag!/revoke_flag!/close_out!and their aasm hooks are gone; the backend create action no longer touches flipperflipper_features.ymlthe trade: no flipper kill switch for the flow anymore — turning it off means a deploy (or withdrawing the open cases).
after merging
manual_verification_call_2026_07_03in the flipper UI (housekeeping only; nothing reads it once this deploys)requestedwith no link. this change gives them access automatically (their case is open), but staff should resend the link on each:VerificationCase.where(status: "requested", link_sent_at: nil)testing
-Pisolation; CI runs no rspec)