test: align loop freshness with configured source scope - #86
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b938566bb7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| expect(freshnessItem).toBeUndefined(); | ||
| expect(reviewed.delta.notifiable).not.toContain("freshness:git"); |
There was a problem hiding this comment.
This replacement removes the only evolution-loop test that verifies a genuinely stale source becomes a blocked freshness:<id> queue item, is notified on its first appearance, and is suppressed on the next unchanged run. The reconciliation tests cover freshness classification, but none exercise the rawQueue/notification transition now that this case always asserts that the item is absent, so a regression in stale-cursor alerting would pass the suite. Keep this unrelated-path case, but retain a separate stale fixture using newer in-scope evidence missed by the incremental cursor.
AGENTS.md reference: AGENTS.md:L132-L132
Useful? React with 👍 / 👎.
|
🎉 This PR is included in version 2.31.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 participant
The end-to-end loop fixture still expected unrelated repository commits to make a path-filtered source stale after #85 corrected that behavior. Update it to require complete/current coverage, no synthetic freshness queue item, and no repeated notification.
The preceding CI run passed 1,118 tests and failed only this outdated assertion. This changes the test contract only; production code remains unchanged. Lint/typecheck and the corrected focused regression pass. Fresh CI passes the full CI-safe suite and both macOS/Windows binary verifiers.