Skip to content

gp_creds: fix use-after-free in gp_count_tickets() #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prabhakarpujeri wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gp_creds: fix use-after-free in gp_count_tickets() #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/gp_creds.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,21 +1105,21 @@ uint32_t gp_count_tickets(uint32_t *min, gss_cred_id_t cred, uint32_t *ccsum)
goto done;
}

do {
err = krb5_cc_next_cred(context, ccache, &cursor, &creds);
if (err != 0 && err != KRB5_CC_END) {
ret_min = err;
ret_maj = GSS_S_FAILURE;
goto done;
for (err = 0; err == 0;
err = krb5_cc_next_cred(context, ccache, &cursor, &creds)) {
if (err == 0) {
krb5_free_cred_contents(context, &creds);

/* TODO: Should we do a real checksum over all creds->ticket data and
* flags in future ? */
(*ccsum)++;
}

krb5_free_cred_contents(context, &creds);

/* TODO: Should we do a real checksum over all creds->ticket data and
* flags in future ? */
(*ccsum)++;

} while (err == 0);
}
if (err != KRB5_CC_END) {
ret_min = err;
ret_maj = GSS_S_FAILURE;
goto done;
}

err = krb5_cc_end_seq_get(context, ccache, &cursor);
if (err != 0) {
Expand Down
Loading