grpc-js: Remove calls from the pick queue immediately when they end - #3078
Merged
murgatroid99 merged 2 commits intoSep 11, 2026
Merged
Conversation
Sermelyan
reviewed
Sep 10, 2026
Co-authored-by: Sergey Melikyan <55602957+Sermelyan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a defense-in-depth fix for the bug reported in #2785 (comment). If, due to another bug, a channel gets stuck in a non-READY state for a long period of time, call references can accumulate in the pick queue, and they aren't removed immediately if they end locally due to cancellation or a deadline. With this change, calls are always immediately removed from the queue when they end.
Also, as suggested in that comment, I made the pick queue a set to make that removal efficient.