feat: publish permissions plugin image#10
Conversation
24a9097 to
3b570af
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b570afd97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /bin/sh -euc '\ | ||
| : "${GITHUB_USER:?GITHUB_USER build arg is required}"; \ | ||
| token="$(cat /run/secrets/github_token)"; \ | ||
| ./gradlew --no-daemon :velocity:build \ |
There was a problem hiding this comment.
Propagate the release version into Gradle
This Gradle invocation never receives versionOverride; with gg.grounds.base-conventions 0.6.0, project.version defaults to local-SNAPSHOT unless that property is set, and the Velocity conventions bake project.version into BuildInfo.VERSION. On v* image releases, GHCR will get a semver tag but the JAR's Velocity plugin metadata and permission-catalog source version will still be local-SNAPSHOT, so the tag version needs to be passed into the Docker build and then into this Gradle command.
Useful? React with 👍 / 👎.
|
Closing this path as superseded. groundsgg/containers#182 now bakes |
Pull Request
Description
Packages the shaded Velocity permissions plugin JAR as the OCI transport image expected by the existing
plugin-velocity-jarHelm chart./jar/plugin.jarghcr.io/groundsgg/plugin-permissions:edgefrommainv*release tags through the shared Grounds workflowType of Change
Related Issues
Testing
Validation performed:
./gradlew test./gradlew spotlessApply./gradlew builddocker buildwith BuildKit credentials/jar/plugin.jarexists and is non-emptygit diff --checkChecklist