Fix false-positive integration-readiness detection from Part F rationale wording#17
Merged
Conversation
awrobel-gd
changed the title
…egex for the "Integration Readiness" field. Update logic to prioritize declared readiness over rationale explanations in both contract and precheck services. Add corresponding unit tests to ensure correct behavior in edge cases.
awrobel-gd
force-pushed
the
fix-contract-e2e
branch
from
1ebda8d to
d023fdd
Compare
mkonopelski-gd
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The contract validator and MCP precheck could misclassify a spec as INTEGRATION_TESTS_READY when Part F's Rationale text merely mentioned that token while explaining it did not apply, wrongly forcing the user to supply an e2e test plan for a LOCAL_ONLY spec.
Entrypoint
is_integration_tests_readyin backend/app/services/contract_validator.py and the identical_is_integration_tests_readyin mcp_server/services/run_generation_precheck.py now match the**Integration Readiness:**field specifically via a new_READINESS_FIELDregex, instead of scanning the whole Part F section for the token.Details
Falls back to the old whole-section token scan only when the labeled field can't be found, so non-standard formatting stays lenient; regression tests were added in both test suites reproducing the real-world wording that triggered the bug.