Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Helm-chart configurable “dynamic Kubernetes query” capability for Chao/Gremlin by introducing a feature flag and an RBAC allowlist that extends the existing gremlin-watcher ClusterRole with additional read-only permissions when enabled.
Changes:
- Add
chao.features.dynamicQueryvalues (flag + default allowlist) to control dynamic query behavior. - Extend the
gremlin-watcherClusterRole rules and Chao container args when the feature is enabled. - Add Helm template validations and helm-unittest coverage; document the feature and defaults in the chart README.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
gremlin/values.yaml |
Introduces chao.features.dynamicQuery and a default RBAC allowlist. |
gremlin/tests/notes_test.yaml |
Adds template validation tests for dynamic query allowlist/verbs constraints. |
gremlin/templates/chao-service-account.yaml |
Conditionally appends allowlist RBAC rules to the gremlin-watcher ClusterRole. |
gremlin/templates/chao-deployment.yaml |
Conditionally enables Chao’s -dynamic_query flag. |
gremlin/templates/_validation.tpl |
Adds validations for allowlist presence and verb restrictions when enabled. |
gremlin/README.md |
Documents dynamic queries, configuration keys, and default allowlist intent. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sirged
approved these changes
Sep 2, 2026
sirged
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the upcoming Dynamic K8s Query feature, add an option to enable it, and it's expanded set of read capabilities.
K8s doesn't have a deny list, only adding allows, so we're just adding some more basic constructs to the list instead of a wildcard by default.