Skip to content

Change: Set mTLS as default and support HTTP by an explicit flag. - #1367

Merged
greenbonebot merged 2 commits into
mainfrom
fix-request-without-cert-validation-alert
Aug 18, 2026
Merged

Change: Set mTLS as default and support HTTP by an explicit flag.#1367
greenbonebot merged 2 commits into
mainfrom
fix-request-without-cert-validation-alert

Conversation

@a-h-abdelsalam

Copy link
Copy Markdown
Contributor

What

Set mTLS as default for openvasd library and only support HTTP when the flag insecure_http is explicitly set to true.

Missing TLS certificates will no longer fall back to HTTP.

Why

Be explicit about using insecure HTTP.
Resolve code scanning alerts.

References

GEA-2017

@a-h-abdelsalam
a-h-abdelsalam requested a review from a team as a code owner August 18, 2026 11:39
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 8d31a28.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@greenbonebot
greenbonebot enabled auto-merge (rebase) August 18, 2026 11:39
@github-actions

Copy link
Copy Markdown

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.37%. Comparing base (efe589d) to head (8d31a28).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1367      +/-   ##
==========================================
- Coverage   98.37%   98.37%   -0.01%     
==========================================
  Files         103      103              
  Lines        6768     6767       -1     
  Branches     1229     1230       +1     
==========================================
- Hits         6658     6657       -1     
  Misses         77       77              
  Partials       33       33              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a-h-abdelsalam
a-h-abdelsalam marked this pull request as draft August 18, 2026 11:43
auto-merge was automatically disabled August 18, 2026 11:43

Pull request was converted to draft

bjoernricks
bjoernricks previously approved these changes Aug 18, 2026
@a-h-abdelsalam
a-h-abdelsalam force-pushed the fix-request-without-cert-validation-alert branch from 50481c7 to 8d31a28 Compare August 18, 2026 12:28
@a-h-abdelsalam
a-h-abdelsalam marked this pull request as ready for review August 18, 2026 12:31
@greenbonebot
greenbonebot enabled auto-merge (rebase) August 18, 2026 12:31
@greenbonebot
greenbonebot merged commit 5672632 into main Aug 18, 2026
27 checks passed
@greenbonebot
greenbonebot deleted the fix-request-without-cert-validation-alert branch August 18, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants