Repository navigation
ci: trust the Postgres repo with a signed-by key, not apt-key - #769
Merged
Merged
Conversation
GitHub's ubuntu-latest runner moved to Ubuntu 26.04, which has no apt-key, so the step that adds the Postgres package repo for the integration tests fails before any of them run.
Pinning the job to Ubuntu 24.04 only put off the failure, since apt-key is gone from newer images. The job moves back to ubuntu-latest and trusts the Postgres repo's key directly.
The job put the binaries of whichever Postgres cluster was listed first on its PATH, which on a runner with its own Postgres could be another version. It now uses 17's, and stops if missing.
MoonBoi9001
changed the title
MoonBoi9001
marked this pull request as ready for review
October 30, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub's
ubuntu-latestrunner moved to Ubuntu 26.04, which has noapt-key, so the Rust test job fails at the step that adds the Postgres package repo and no integration test runs on any PR. This trusts that repo's key through asigned-bykeyring instead, and puts the binaries of the Postgres 17 the job installs on the test PATH, rather than those of whichever cluster is listed first.