via marker improvements - #461
Merged
Merged
Conversation
This reverts commit cb41039.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements four improvements for the via marker:
Try it here: https://graphhopper.com/maps-dev/via_marker/
Drag from route works obviously only on desktop (hover) and looks like:
To make via markers more consistent with the transparent circle on that route I took the opportunity and changed the style of the via markers too (first commits). In master the via markers are a bit thin leading to rather small numbers. When changing this to a circle this looks cleaner, is consistent to the dragging style and the font can be also slightly bigger improving overall experience when using multiple markers.
Before:
After:
Now that the anchor is at the center of the icon the marker gets now transparent to achieve a better placement.