Repository navigation
Preserve shared throttle buckets across decorator recreation - #390
Open
Sarbajit-Sengupta wants to merge 1 commit into
Open
Sarbajit-Sengupta wants to merge 1 commit into
Sarbajit-Sengupta wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreating a named throttle decorator overwrites its persisted token bucket. Starting another worker against the same cache therefore restores the full allowance even when the existing worker has just exhausted it.
Initialize the bucket with atomic
Cache.addso an existing bucket survives decorator construction. Two deterministic tests exercise a reused connection and an independently opened connection to the same directory, then verify the next call waits for the shared allowance.Validation: both regressions fail before the change; 181 core/Fanout/Deque/Index/recipe tests pass on Python 3.13. Blue's formatter API and equivalent Ruff style checks pass. Django integration tests were not run because the dependency download repeatedly reset.