Skip to content

Subgroup_size_control enables subgroups #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-baker merged 3 commits into from
Aug 12, 2026
Merged

Subgroup_size_control enables subgroups #4693

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d832d51
Subgroup_size_control enables subgroups
alan-baker Aug 12, 2026
473911b
changes for review
alan-baker Aug 12, 2026
506a7c2
Merge branch 'main' into subgroup-size-dependencies
alan-baker Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/webgpu/shader/validation/extension/subgroup_size_control.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ export const g = makeTestGroup(UniqueFeaturesAndLimitsShaderValidationTest);

g.test('enable_subgroup_size_control_requires_subgroups')
.desc(
`Checks that enabling the WGSL extension subgroup_size_control without also enabling the
subgroups extension is a compilation error.`
`Checks that enabling the WGSL extension subgroup_size_control also enables the
subgroups extension.`
)
.params(u => u.combine('enableSubgroups', [false, true] as const))
.beforeAllSubcases(t => {
Expand All @@ -24,12 +24,15 @@ g.test('enable_subgroup_size_control_requires_subgroups')
const { enableSubgroups } = t.params;

t.expectCompileResult(
enableSubgroups,
true,
`
${enableSubgroups ? 'enable subgroups;' : ''}
enable subgroup_size_control;
@group(0) @binding(0) var<storage, read_write> out : u32;
@compute @workgroup_size(1)
fn main() {}
fn main(@builtin(subgroup_size) size : u32) {
out = size;
}
`
);
});
Expand Down
Loading