Repository navigation
Add forms-product-page base URL to envvars for forms-admin review app - #2403
Merged
lfdebrux merged 1 commit intoOct 19, 2026
Merged
Conversation
lfdebrux
force-pushed
the
ldeb-add-review-apps-forms-admin-settings-product-page-url
branch
from
October 14, 2026 11:49
e7444c7 to
aeaf08c
Compare
lfdebrux
marked this pull request as ready for review
October 14, 2026 12:49
PR govuk-forms/forms-admin#3206 changes forms-admin to expect the URL for the forms-product-page app in its environment variables. As review apps for forms-runner don't deploy forms-product-page, instead we use the production URL.
lfdebrux
force-pushed
the
ldeb-add-review-apps-forms-admin-settings-product-page-url
branch
from
October 15, 2026 09:50
aeaf08c to
926c9cd
Compare
Contributor
|
🎉 A review copy of this PR has been deployed! It is made of up two components It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
theseanything
approved these changes
Oct 16, 2026
lfdebrux
deleted the
ldeb-add-review-apps-forms-admin-settings-product-page-url
branch
October 19, 2026 05:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
PR govuk-forms/forms-admin#3206 changes forms-admin to expect the URL for the forms-product-page app in its environment variables. As review apps for forms-runner don't deploy forms-product-page, instead we use the production URL.
Things to consider when reviewing