Skip to content

Remove aws_shield_application_layer_automatic_response - #2329

Merged
whi-tw merged 1 commit into
mainfrom
remove-shield-app-layer-auto-response
Oct 20, 2026
Merged

whi-tw merged 1 commit into
mainfrom
remove-shield-app-layer-auto-response

Conversation

@whi-tw

@whi-tw whi-tw commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/t0XWPXLU/3329-use-only-anti-ddos-managed-rule-group-not-shields-application-layer-mitigation

AWS' app-level ddos protection is no longer offered via
Shield Advanced. We have already configured the new offering,
so this is just tidying up.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> forms/account apply on the relevant environments (dev, staging and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

AWS' app-level ddos protection is no longer offered via
Shield Advanced. We have already configured the new offering,
so this is just tidying up.
Copilot AI balanced review requested due to automatic review settings October 20, 2026 09:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Replacement protection is configured, no dangling references remain, and no blocking issues were identified.

No open issues 🎉

What changed in this PR

Removes the legacy Shield Advanced application-layer automatic response now that replacement anti-DDoS managed rules are configured.

Changes:

  • Deletes the CloudFront automatic-response resource.
  • Leaves Shield protection and response-team configuration unchanged.
File Description
infra/​deployments/​forms/​health/​shield.tf Removes the legacy CloudFront application-layer automatic response.

Review effort: Balanced

@whi-tw
whi-tw added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 37b97c5 Oct 20, 2026
19 checks passed
@whi-tw
whi-tw deleted the remove-shield-app-layer-auto-response branch October 20, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants