Repository navigation
Remove forms-product-page support URL from forms-admin envvars - #2323
Merged
lfdebrux merged 2 commits intoOct 19, 2026
Merged
Conversation
The forms-product-page app is hosted at `www.forms.service.gov.uk`. However, in places where was pass the URL for that app to other apps/services, we've been using `forms.service.gov.uk`. This does work because there is a 301 permanent redirect from `forms.service.gov.uk` to `www.`, but it might be preferable to avoid that redirect when it's not necessary. This commit updates any places where we have written the product pages base URL to make sure that the `www.` subdomain part is included.
forms-admin no longer needs the forms-product-page support URL as an environment variable (see PR govuk-forms/forms-admin#3207), so we can remove it from our Terraform.
theseanything
approved these changes
Oct 16, 2026
lfdebrux
deleted the
ldeb-add-forms-admin-variable-product-page-base-url
branch
October 19, 2026 05:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
forms-admin no longer needs the forms-product-page support URL as an environment variable (see PR govuk-forms/forms-admin#3207), so we can remove it from our Terraform.
Also, while working on these changes I realised that in some places we are using
forms.service.gov.ukin some places for the product pages base URL, but that is just a redirect towww.forms.service.gov.uk, so we can reduce requests clients need to make by making sure we include thewww.subdomain when writing URLs for forms-product-page.Things to consider when reviewing
Reminders
If you've made changes to the deployer role (files in
modules/deployer-access):make <environment> forms/account applyon the relevant environments (dev,stagingand/orprod)apply-forms-terraform-<environment>pipelines have run successfully