Repository navigation
Allow everyone in the team to view Grafana dashboards - #2321
Merged
Merged
Conversation
theseanything
changed the title
Everyone on the team should be able to look at dashboards, but until now only members of govuk-forms-devs and govuk-forms-infrastructure could sign in. Grafana picks the first matching role, so members of the admin or editor teams keep their higher role. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
theseanything
force-pushed
the
grafana-viewer-role
branch
from
October 14, 2026 17:04
452dbaf to
5926b8c
Compare
theseanything
changed the title
theseanything
marked this pull request as ready for review
October 14, 2026 17:04
theseanything
requested review from
a team
and
a balanced review from Copilot
October 14, 2026 17:04
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Configuration is wired consistently across environments, preserves role precedence, and has no identified blocking issues.
0 open findings
What changed in this PR
Extends Grafana dashboard access to the govuk-forms-all GitHub team while preserving existing admin and editor roles.
Changes:
- Adds optional viewer-team configuration and role mapping.
- Enables viewer access in development, staging, and production.
- Documents viewer access and denial for unmatched users.
| File | Description |
|---|---|
| infra/modules/grafana/variables.tf | Adds optional viewer-team input. |
| infra/modules/grafana/README.md | Documents viewer access rules. |
| infra/modules/grafana/ecs.tf | Maps viewer teams after higher-priority roles. |
| infra/deployments/forms/tfvars/staging.tfvars | Enables team-wide viewing in staging. |
| infra/deployments/forms/tfvars/production.tfvars | Enables team-wide viewing in production. |
| infra/deployments/forms/tfvars/dev.tfvars | Enables team-wide viewing in development. |
| infra/deployments/forms/inputs.tf | Adds viewer teams to deployment settings. |
| infra/deployments/forms/health/grafana.tf | Passes viewer teams to the Grafana module. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
whi-tw
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/gbx5hFDS/518-show-number-of-submissions-per-week-kpi-in-grafana
Only members of
govuk-forms-devsandgovuk-forms-infrastructurecan sign in to Grafana at the moment.This allow anyone in
govuk-forms/govuk-forms-allGitHub team to login so anyone in the team can view dashboards.Roles are checked in order (admin, then editor, then viewer), so people in the admin or editor teams keep their higher role.