Repository navigation
Split deployer IAM policy into scoped policies - #2320
Merged
Merged
Conversation
Adding the submission events role statement took the iam policy past the 6,144 character managed policy limit. Split it into policies for ECS tasks, pipelines and service access. The permissions are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The policy split preserves existing permissions while resolving the managed-policy size limit.
0 open findings
What changed in this PR
Splits the oversized deployer IAM policy into smaller, scoped managed policies while preserving permissions and Terraform state.
Changes:
- Separates ECS, pipeline, and service-access permissions.
- Migrates the existing policy and attachment to
iam_ecs. - Adds and attaches two new scoped policies.
| File | Description |
|---|---|
infra/modules/deployer-access/policy.tf |
Defines, migrates, and attaches the scoped IAM policies. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lfdebrux
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Applying #2314 to staging failed because the deployer's
iampolicy went over the 6,144 character limit for managed policies.This splits it into three policies:
iam_ecs: ECS task roles and policiesiam_pipelines: CodeBuild, EventBridge and Lambda roles and policiesiam_service_access: roles and users for other AWS services and Auth0The permissions are unchanged.
Things to consider when reviewing
movedblocks keep the existing policy asiam_ecs, so it's updated in place rather than replaced.Reminders
If you've made changes to the deployer role (files in
modules/deployer-access):make <environment> forms/account applyon the relevant environments (dev,stagingand/orprod)apply-forms-terraform-<environment>pipelines have run successfully