Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The section bypasses the routing feature flag and advertises actions unavailable for some question configurations.
3 open findings
What changed in this PR
Adds routing information and links to the saved-question editing screen.
Changes:
- Shows routing guidance based on question type, position, and existing routes.
- Adds translated content and view specs for the new section.
| File | Description |
|---|---|
| spec/views/pages/edit.html.erb_spec.rb | Tests routing messages, links, and visibility. |
| config/locales/en.yml | Adds routes-section heading and messages. |
| app/views/pages/_form.html.erb | Conditionally displays the routes section. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
28991a8 to
784e2cd
Compare
Add a routes section to edit question page, which only appears if it's a selection question with only one option. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Questions that aren't selection questions with only one option can have unconditional routes, which let people skip later questions. Show a section on the edit question page for these questions, linking to the question's routes. The section isn't shown on the last question in the form, as there are no later questions to skip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When a question has routes, show a message in the routes section of the edit question page saying so, with a link to edit the question's routes. This message appears on any question with routes, including the last question in the form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
784e2cd to
bd23cc8
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3229.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
What problem does this pull request solve?
Trello card: https://trello.com/c/Yp8LZhTj/3291-add-routing-content-to-edit-question-screen-for-saved-questions
Adds a routes section to the edit questions page. This appears under certain conditions, with different content.
For a selection option only one answer question with no routes and 10 or fewer selection options
For any question that qualifies for unconditional routes (not select only one option (unless it has more than 10 options) and not the last question in the form)
For any question with routes
Things to consider when reviewing