Repository navigation
Fixes for Welsh tasks in the draft form task list - #3205
Merged
stephencdaly merged 4 commits intoOct 16, 2026
Merged
stephencdaly merged 4 commits into
stephencdaly merged 4 commits into
Conversation
When checking whether the draft form has changed from the live version when calculating the status of the tasks to make only the English or Welsh versions of the form live, use the draft form document from the database rather than regenerating it. The draft form document is updated after any changes to the form are saved, so it will always be up to date.
Only calculate the `make_only_english_live_status` and `make_only_welsh_live_status` task statuses when we will show the corresponding tasks on the task list. Update the task list service to use the presence of the task statuses to decide whether these tasks are shown. This also fixes the task status count, as it was incorrectly counting all of the make live tasks when only a subset were ever shown to the user. Co-Authored-By: Claude
If the tasks to make the English and Welsh versions of the form live separately would be shown, but the current user does not have the permission to make the form live the task status count was incorrectly including these tasks. Co-Authored-By: Claude
stephencdaly
marked this pull request as draft
October 14, 2026 10:36
This task is optional, so should be excluded from the task count as we do for other optional tasks.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3205.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
stephencdaly
marked this pull request as ready for review
October 14, 2026 10:54
stephencdaly
changed the title
theseanything
approved these changes
Oct 16, 2026
stephencdaly
deleted the
only-calculate-make-language-live-task-statuses-when-required
branch
October 16, 2026 08:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following: