Skip to content

cl loadTemplateClass: support conf.TypeIgnore; loadOutsideMethod: skip specialized & operator(); tool: cfg.NoManglingIgnore - #908

Merged
xushiwei merged 4 commits into
goplus:mainfrom
xushiwei:q
Oct 4, 2026
Merged

xushiwei merged 4 commits into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

@xushiwei xushiwei commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

No description provided.

…p specialized & operator(); tool: cfg.NoManglingIgnore
@xushiwei xushiwei changed the title cl loadTemplateClass: support conf.TypeIgnore; loadOutsideMethod: ski… cl loadTemplateClass: support conf.TypeIgnore; loadOutsideMethod: skip specialized & operator(); tool: cfg.NoManglingIgnore Oct 4, 2026
@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.47%. Comparing base (7b29254) to head (28ebec8).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cl/preload.go 58.33% 5 Missing ⚠️
cl/type.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
- Coverage   88.51%   88.47%   -0.05%     
==========================================
  Files          21       21              
  Lines        2047     2074      +27     
==========================================
+ Hits         1812     1835      +23     
- Misses        235      239       +4     
Flag Coverage Δ
llgo-tests 88.47% <80.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Reviewed the full diff (38688e1...562f12a) across all 8 changed files. The core changes look consistent and correct:

  • NoManglingIgnore config field + wiring (tool/config.go, cmd/llcppg/gen.go, cl/func.go) mirrors the existing IgnoreInline pattern cleanly.
  • wchar_t support (Type_WChar -> cWcharT -> c.WcharT) verified to resolve: c.WcharT exists in goplus/lib@v0.5.8 (ctypes_32bit.go, ctypes_windows.go), and go vet ./cl/ passes.
  • varHasInitExpr adding Cursor_BinaryOperator, loadTemplateClass honoring TypeIgnore, and the operator()/specialized-method quiet-ignore paths are consistent with surrounding patterns.
  • No performance regression: the new clang.VisitChildren in logf runs only on logging/warning paths (gated by debug flags or non-quiet ignores) and early-breaks on the first child.

Two minor robustness notes are left inline. Both are low severity (no crash — goNodePos tolerates an invalid cursor).

Comment thread cl/ctx.go
Comment thread cl/preload.go
@xushiwei
xushiwei merged commit 9d0dcb8 into goplus:main Oct 4, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant