Skip to content

fix(script): pass current stable Clippy match lint - #930

Closed
ratovarius wants to merge 1 commit into
googleworkspace:mainfrom
ratovarius:fix/current-clippy-baseline
Closed

fix(script): pass current stable Clippy match lint#930
ratovarius wants to merge 1 commit into
googleworkspace:mainfrom
ratovarius:fix/current-clippy-baseline

Conversation

@ratovarius

@ratovarius ratovarius commented Sep 11, 2026

Copy link
Copy Markdown

Description

Current stable Clippy rejects the nested Apps Script JSON filename match under the required -D warnings gate. Use a guarded match arm so appsscript.json remains the only accepted JSON source file, with the same behavior for all other extensions.

Fixes ratovarius#8.

Scope and integration

This is build-maintenance work, not a new Workspace feature. The same two-file Clippy patch is currently copied into each of #931#937 so those branches pass the current stable-toolchain lint gate against the present upstream base. Merge this small common change first where practical; the remaining PRs can then be refreshed to omit the duplicate patch. The seven feature/fix PRs can otherwise be evaluated individually.

Local independent agent review found no outstanding findings. This does not represent upstream maintainer approval.

Validation

cargo fmt --all -- --check, cargo test --workspace --locked --offline (783 tests), and cargo clippy --workspace --locked --offline -- -D warnings passed on Rust 1.98.1. Independent review confirmed behavior equivalence.

Limits

No new CLI behavior; dry-run output is not applicable.

Checklist

  • Follows AGENTS.md; no generated Google client crates.
  • Formatting check passed.
  • Required strict Clippy check passed.
  • Existing regression tests verify unchanged file-selection behavior.
  • Includes a changeset.

@changeset-bot

changeset-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 48f1b8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla

google-cla Bot commented Sep 11, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ratovarius

Copy link
Copy Markdown
Author

Closing this proposal by author request to focus the initial upstream contribution on #937 (preserve saved credentials after authentication failures).

This work remains implemented and maintained in the public fork, https://github.com/ratovarius/cli, with tracking in ratovarius#8 and integration in ratovarius#10. Further development of this item will continue in the fork. This closure does not indicate rejection by upstream maintainers.

The small Clippy cleanup is already included as a separately reviewable commit in #937, so that pilot does not depend on this PR being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core CLI parsing, commands, error handling, utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep the required Clippy check passing on current Rust

2 participants