docs(gmail): correct draft send command tip - #924
Open
ZIFeIYUuuuuuu wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 756ad75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ZIFeIYUuuuuuu
force-pushed
the
fix/914-correct-draft-send-tip
branch
from
September 9, 2026 10:22
9780b42 to
756ad75
Compare
Collaborator
|
/gemini review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the Gmail
--draftsend command shown to usersProblem
After
gws gmail +send --draft(and the other Gmail helpers that share this path) succeeds, the printed tip tells users to run:That is not valid discovery command syntax: resources and methods are separate positional arguments, and request parameters/body use
--paramsand--json. Copying the tip therefore results in a command that fails before sending the draft.Changes
draft_send_tip().Validation
cargo test -p google-workspace-cli helpers::gmail::tests::test_draft_send_tip_uses_valid_discovery_command_syntax -- --exact --nocapture: 1 passed.cargo test -p google-workspace-cli helpers::gmail::tests -- --nocapture: 113 passed.cargo fmt --all -- --check: passed.cargo clippy -p google-workspace-cli -- -D warnings -A clippy::collapsible-match: passed; the allow covers an existing unrelated warning inhelpers/script.rs.git diff --check: passed.This is a user-facing documentation/error-message correction only; the draft creation and send API calls are unchanged. Closes #914.