Repository navigation
fix(spanner): remove unused mutex_m require - #276
Open
torreypayne wants to merge 1 commit into
Open
torreypayne wants to merge 1 commit into
torreypayne wants to merge 1 commit into
Conversation
RequestIdInterceptor required mutex_m but only uses the core Mutex class, and the gemspec never declared mutex_m. Ruby 3.4 made mutex_m a bundled gem, so require "google/cloud/spanner" raised LoadError in any bundle that didn't list it. Drop the require, and the development Gemfile pin that kept CI from noticing.
efevans
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestIdInterceptorrequiredmutex_mbut only uses coreMutex, and the gemspec never declaredmutex_m. Ruby 3.4 mademutex_ma bundled gem, sorequire "google/cloud/spanner"raisesLoadErrorin apps that don't list it (2.34.0 through 2.37.1). This removes the require, and the development Gemfile pin that hid the problem from CI.Tested:
Fixes #275