Skip to content

impl(bigquery): use arrow format with jobs.query - #6472

Draft
alvarowolfx wants to merge 6 commits into
googleapis:mainfrom
alvarowolfx:impl-bq-arrow-jobs-query
Draft

impl(bigquery): use arrow format with jobs.query#6472
alvarowolfx wants to merge 6 commits into
googleapis:mainfrom
alvarowolfx:impl-bq-arrow-jobs-query

Conversation

@alvarowolfx

Copy link
Copy Markdown
Contributor

Trying out arrow support on jobs.query. This is gonna break on CI because support for it is behind an allowlist.

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Aug 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Arrow serialization in BigQuery query results, allowing the SDK to request and process Arrow record batches directly. Key changes include updating the query execution to request Arrow format with Zstd compression, implementing Arrow-to-Value conversion for various data types, and parsing Arrow schemas into BigQuery table schemas. Feedback on the changes suggests using unsigned_abs() to prevent overflow panics when formatting intervals, avoiding unnecessary clones when parsing range objects, and ensuring DataType::Interval is correctly mapped to "INTERVAL" in the schema conversion logic.

Comment thread src/bigquery/src/query/row.rs Outdated
Comment thread src/bigquery/src/datatypes.rs Outdated
Comment thread src/bigquery/src/query/schema.rs Outdated
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.97797% with 159 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.35%. Comparing base (a76f20a) to head (b5c96c7).

Files with missing lines Patch % Lines
src/bigquery/src/query/row.rs 57.28% 129 Missing ⚠️
src/bigquery/src/query/query_handle.rs 61.76% 13 Missing ⚠️
src/bigquery/src/query/schema.rs 78.04% 9 Missing ⚠️
src/bigquery/src/datatypes.rs 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6472      +/-   ##
==========================================
- Coverage   96.52%   96.35%   -0.17%     
==========================================
  Files         304      304              
  Lines       87969    88401     +432     
==========================================
+ Hits        84908    85180     +272     
- Misses       3061     3221     +160     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant