Skip to content

test(o11y): add Discovery LRO tracing error integration tests#5892

Merged
haphungw merged 2 commits into
googleapis:mainfrom
haphungw:fix-lro-tracing-discovery-errors
Jun 22, 2026
Merged

test(o11y): add Discovery LRO tracing error integration tests#5892
haphungw merged 2 commits into
googleapis:mainfrom
haphungw:fix-lro-tracing-discovery-errors

Conversation

@haphungw

Copy link
Copy Markdown
Contributor

Add tracing integration tests for Discovery LRO error paths.

Stacked on top of #5891

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces integration tests for Long-Running Operation (LRO) tracing under tests/o11y, covering both Showcase (GAPIC) and Discovery-based client pollers across success, logical error, transient error, and permanent error scenarios. Feedback on the changes includes removing redundant inner #[cfg(google_cloud_unstable_tracing)] attributes since the entire file is already gated with that configuration, and addressing a discrepancy where the LRO Wait span status remains UNSET instead of ERROR during logical errors in Discovery LROs.

Comment thread tests/o11y/src/lro_tracing.rs Outdated
Comment thread tests/o11y/src/lro_tracing.rs
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.90%. Comparing base (737706a) to head (27e37b8).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5892   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files         234      234           
  Lines       59451    59451           
=======================================
+ Hits        58204    58208    +4     
+ Misses       1247     1243    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haphungw haphungw force-pushed the fix-lro-tracing-discovery-errors branch 2 times, most recently from bc2a064 to 89f0be9 Compare June 16, 2026 19:05
Comment thread src/lro/src/internal/discovery.rs
Comment thread tests/o11y/src/lro_tracing.rs Outdated
Comment thread tests/o11y/src/lro_tracing.rs Outdated
@haphungw haphungw force-pushed the fix-lro-tracing-discovery-errors branch 3 times, most recently from 0d587a2 to 9af8bb8 Compare June 17, 2026 21:34
@haphungw haphungw force-pushed the fix-lro-tracing-discovery-errors branch from 9af8bb8 to 7515723 Compare June 18, 2026 18:29
@haphungw haphungw marked this pull request as ready for review June 18, 2026 18:38
@haphungw haphungw requested a review from a team as a code owner June 18, 2026 18:38
@haphungw haphungw requested a review from westarle June 18, 2026 18:39
Comment thread src/lro/src/internal/discovery.rs Outdated
@haphungw haphungw enabled auto-merge (squash) June 22, 2026 20:09
@haphungw haphungw merged commit bbfc163 into googleapis:main Jun 22, 2026
41 checks passed
@haphungw haphungw deleted the fix-lro-tracing-discovery-errors branch June 22, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants