Repository navigation
fix: include version headers in long running operations - #19059
Open
daniel-sanche wants to merge 6 commits into
Open
daniel-sanche wants to merge 6 commits into
daniel-sanche wants to merge 6 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the GAPIC generator templates to include API version headers in the metadata for long-running operations (LRO) and mixin services, and updates unit and integration tests to verify these headers. A review comment correctly points out that making the API version header tests unconditional could lead to failures on older versions of google-api-core where version_header is unavailable; it suggests conditionally skipping the tests using the HAS_GOOGLE_API_CORE_VERSION_HEADER constant.
…_lro-api-version-header-576380032
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated Python GAPIC clients do not send the x-goog-api-version header when making google.longrunning.Operations calls over gRPC. This PR fixes the gap in the generator