Repository navigation
test(bigtable): set up accelerator system test environment and harness - #18787
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces integration and concurrency tests for the Google Cloud Bigtable accelerator, including pytest configurations, base test classes, a state-tracking test harness, and multi-process/multi-threaded concurrency tests. The review feedback suggests several key improvements: cleaning up empty row dictionaries from the state model in _harness.py to prevent memory retention, switching the multiprocessing start method from fork to spawn in test_concurrency_async.py to avoid gRPC-related deadlocks, and adopting a shared monotonic deadline pattern when joining background processes during cleanup to prevent excessive blocking.
mutianf
changed the title
mutianf
commented
Nov 13, 2026
- Increase DELETE_AFTER_WRITE_GUARD_OPS from 128 to 512. - Remove empty row dictionaries from ExpectedState._rows on delete_range_from_column and delete_from_family. - Generate multi-CF, multi-column mutation batches in RandomOps.build_mutation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up the shared Cloud Bigtable accelerator system-test environment (
conftest.py,pytest.ini,_harness.py,_base_async.py,_base_autogen.py), includingBIGTABLE_TEST_APP_PROFILEauto-injection,BIGTABLE_ACCELERATOR_BINbinary override, andExpectedState/ProcessIntrospectorhelpers.