feat(bigframes): add ai.embed and ai.similarity to bigquery accessor - #17927
Open
sycai wants to merge 2 commits into
Open
feat(bigframes): add ai.embed and ai.similarity to bigquery accessor#17927sycai wants to merge 2 commits into
sycai wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames AITVFMixin to AIMixin and adds embed and similarity methods to the AIMixin class in series_mixins.py to support BigQuery AI embeddings and similarity calculations, along with corresponding unit tests. The review feedback highlights a shadowing issue in the new methods where the session parameter shadows the imported session module, which would cause failures when session is None. To resolve this, it is recommended to import bigframes at the module level and fall back to bigframes.session when the parameter is not provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I chose to define functions under the mixin instead of the code generator because of several function gaps.
We may onboard the ai functions to the code generator some day in the future. Tracking: b/540011825
Internal issue: b/517233441