Skip to content

feat(sqlalchemy-spanner): export MAX_SIZE constant - #17922

Open
sakthivelmanii wants to merge 1 commit into
mainfrom
feat-spanner-export-max-size
Open

feat(sqlalchemy-spanner): export MAX_SIZE constant#17922
sakthivelmanii wants to merge 1 commit into
mainfrom
feat-spanner-export-max-size

Conversation

@sakthivelmanii

Copy link
Copy Markdown
Contributor

Why?

Promoting _max_size to public MAX_SIZE (and dialect.max_size) allows cross-dialect applications to inspect Spanner's STRING(MAX) limit through the public API. It eliminates private symbol imports while preserving full backward compatibility for existing code.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@sakthivelmanii
sakthivelmanii requested a review from a team as a code owner July 28, 2026 12:19

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request exposes the MAX_SIZE constant from the sqlalchemy_spanner module, making it publicly accessible and integrating it into the SpannerDialect class. It also adds a unit test to verify the export and the behavior of the int_from_size helper function. There are no review comments, so I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant