chore(firestore): disable promise lint rules in test overrides - #9251
Open
dlarocque wants to merge 1 commit into
Open
chore(firestore): disable promise lint rules in test overrides#9251dlarocque wants to merge 1 commit into
dlarocque wants to merge 1 commit into
Conversation
Expand the Firestore test override glob to match nested test subdirectories and disable `promise/always-return` and `promise/catch-or-return`.
product-auto-label
Bot
added
the
api: firestore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the .eslintrc.json configuration file to recursively match TypeScript test files under the handwritten/firestore/dev/test and handwritten/firestore/dev/system-test directories. Additionally, it disables the promise/always-return and promise/catch-or-return ESLint rules for these test files. There are no review comments, so no additional feedback is provided.
MarkDuckworth
approved these changes
Sep 4, 2026
MarkDuckworth
left a comment
MarkDuckworth
left a comment
Contributor
There was a problem hiding this comment.
This is fine. I was planning to eventually address all of these issues d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the Firestore test override glob to match nested test subdirectories and disable
promise/always-returnandpromise/catch-or-return.