chore(firestore): add --exit flag to test-only and conformance - #9250
Open
dlarocque wants to merge 1 commit into
Open
chore(firestore): add --exit flag to test-only and conformance#9250dlarocque wants to merge 1 commit into
--exit flag to test-only and conformance#9250dlarocque wants to merge 1 commit into
Conversation
Pass `--exit` to mocha in test-only and conformance to ensure Node terminates once tests complete. This prevents test runner from hanging on open grpc streams and background timer handles in modern node versions.
product-auto-label
Bot
added
the
api: firestore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the conformance and test-only scripts in handwritten/firestore/package.json to include the --exit flag for mocha execution, ensuring that the test processes exit after completion. There are no review comments, so I have no feedback to provide.
MarkDuckworth
approved these changes
Sep 4, 2026
MarkDuckworth
left a comment
MarkDuckworth
left a comment
Contributor
There was a problem hiding this comment.
Are we seeing instances of these script hang at the end of testing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
--exitto mocha in test-only and conformance to ensure Node terminates once tests complete. This prevents test runner from hanging on open grpc streams and background timer handles in modern node versions.This technically could hide bugs in code that cause our tests to hang.