Repository navigation
Conversation
…temptDiscarded The test intermittently times out because of a deadlock in publish hedging, tracked in googleapis#15008. It is a bug in the library rather than a timing problem in the test. Disable the test until the deadlock is resolved so that it stops failing unrelated changes. It should be re-enabled together with that change. b/580634974
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables the testPermanentErrorOnHedgedAttemptDiscarded test in PublisherImplTest.java by adding the @Ignore annotation, citing an intermittent deadlock issue in publish hedging. I have no feedback to provide on this change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PublisherImplTest.testPermanentErrorOnHedgedAttemptDiscardedfails intermittently with:The cause is a deadlock in publish hedging, tracked in #15008. It is a bug in the library, not a timing problem in the test, so raising the test's timeout would not help. Looping the unmodified test locally reproduced it about once in 1,900 runs, with a JVM-reported deadlock each time.
This PR only adds
@Ignoreso the test stops failing unrelated changes. It does not address the deadlock. The test should be re-enabled together with the change that does.With this change
PublisherImplTestruns 49 tests with 3 skipped (this one plus the two that were already ignored), andfmt-maven-plugin:checkis clean forgoogle-cloud-pubsub.Seen in
ci / split-units (java-pubsub, 8): https://github.com/googleapis/google-cloud-java/actions/runs/41114451056/job/124265733068b/580634974