[lqiu96]

Summary

Simplifies FieldValue.getBooleanValue() to check "true" and "false" once while preserving the existing IllegalStateException contract.

Previously, getBooleanValue() validated both literals with Preconditions.checkState(stringValue.equalsIgnoreCase("true") || stringValue.equalsIgnoreCase("false"), ...) and then called Boolean.parseBoolean(stringValue) (which performs "true".equalsIgnoreCase(stringValue) a second time, since Boolean.parseBoolean on its own would return false for invalid strings).

Changes

• FieldValue:
  • Check "true".equalsIgnoreCase(stringValue) and "false".equalsIgnoreCase(stringValue) directly in getBooleanValue() and throw IllegalStateException if neither matches.
  • Add an inline comment explaining why explicit validation is used instead of delegating directly to Boolean.parseBoolean.
  • Remove the now-unused Preconditions.checkState import.
• FieldValueTest:
  • Added testGetBooleanValue covering "true", "false", mixed case, and invalid strings throwing IllegalStateException.

Verification

• mvn test -pl java-bigquery/google-cloud-bigquery -Dtest=FieldValueTest (7 passed)
• mvn test -pl java-bigquery/google-cloud-bigquery -Dtest=FieldValueListTest (5 passed)

[gemini-code-assist]

Code Review

This pull request refactors the getBooleanValue method in FieldValue.java to explicitly validate and parse boolean strings ("true" and "false" case-insensitively) and throw an IllegalStateException for invalid inputs, replacing the previous usage of Guava's checkState and Boolean.parseBoolean. Additionally, corresponding unit tests have been added in FieldValueTest.java to verify this behavior. There are no review comments, and I have no feedback to provide.