Skip to content

test(pubsub): deflake SubscriberTest.testStreamAckDeadlineIsSetCorrectly #15005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blakeli0 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

test(pubsub): deflake SubscriberTest.testStreamAckDeadlineIsSetCorrectly #15005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions java-pubsub/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/SubscriberTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,10 @@ public void testStreamAckDeadlineIsSetCorrectly() throws Exception {
fakeSubscriberServiceImpl.getLastSeenRequest().getStreamAckDeadlineSeconds());

subscriber.stopAsync().awaitTerminated();
// awaitTerminated() only covers the client side. The fake server finds out asynchronously
// that the stream was closed, so wait for that before starting the next subscriber. Otherwise
// the old stream may still be counted, and its request returned, by the assertions below.
fakeSubscriberServiceImpl.waitForClosedStreams(1);

// Deadline is higher than the allowed streamAckDeadline.
maxDurationPerAckExtension = 700;
Expand All @@ -265,6 +269,7 @@ public void testStreamAckDeadlineIsSetCorrectly() throws Exception {
fakeSubscriberServiceImpl.getLastSeenRequest().getStreamAckDeadlineSeconds());

subscriber.stopAsync().awaitTerminated();
fakeSubscriberServiceImpl.waitForClosedStreams(2);

// Deadline is within the allowed limits for streamAckDeadline.
maxDurationPerAckExtension = 100;
Expand All @@ -280,6 +285,7 @@ public void testStreamAckDeadlineIsSetCorrectly() throws Exception {
fakeSubscriberServiceImpl.getLastSeenRequest().getStreamAckDeadlineSeconds());

subscriber.stopAsync().awaitTerminated();
fakeSubscriberServiceImpl.waitForClosedStreams(3);

// maxDurationPerAckExtension is unset.
subscriber = startSubscriber(getTestSubscriberBuilder(testReceiver));
Expand Down
Loading