Repository navigation
fix(bigtable): do not retry on negative RetryInfo delay in RetryingVRpc - #15004
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a guard against negative retry delays in RetryingVRpc to prevent unexpected retry behavior, along with a new unit test to verify this logic. The review feedback points out that the unit test uses an already expired deadline (0 milliseconds), which could lead to false positives if test execution is delayed. It is recommended to use a deadline far in the future to ensure the test's robustness.
mutianf
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not retry server errors when
RetryInfo.retry_delayis negative, preventing a negative duration from inverting the remaining-deadline check inRetryingVRpc.Active.shouldRetry.Also document why a 0s
RetryInfodelay transitions directly toIdleand is capped by the server.