Repository navigation
Conversation
- gax-bom pinned the released google-cloud-shared-config 1.17.0 from Maven Central. Point it at the in-repo POM, as first-party-dependencies does. - Remove the inline maven-checkstyle-plugin version. The module now inherits it from pluginManagement. - Remove the enforce-banned-duplicate-classes skip. The in-repo parent defines that execution, so the workaround is not necessary.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the parent POM google-cloud-shared-config version to 1.27.0 and configures its relative path. It also removes the explicit version declaration for maven-checkstyle-plugin and deletes the configuration that skipped the enforce-banned-duplicate-classes execution for maven-enforcer-plugin. There are no review comments, and I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the in-repo
google-cloud-shared-configas the parent ofgax-bom. This is the follow-up from #14962 (comment).gax-bompinned the releasedgoogle-cloud-shared-config1.17.0from Maven Central. It now uses the in-repo POM, in the same form asfirst-party-dependencies.maven-checkstyle-pluginversion. The module inherits3.6.0from<pluginManagement>.enforce-banned-duplicate-classesskip. The in-repo parent defines that execution, and the rule passes.The effective
<dependencyManagement>ofgax-bomis the same before and after (12 entries), so importers of the BOM see no change.