Repository navigation
test(bigquerystorage): run flaky public-table read tests on v1 only - #14991
Merged
Merged
Conversation
Re-enable testSimpleReadAndResume and testUniverseDomainWithMatchingDomain in v1.it.ITBigQueryStorageReadClientTest while disabling testSimpleReadAndResume in v1beta1 and v1beta2 ITBigQueryStorageTest so duplicate public-dataset CreateReadSession tests run on v1 only. Refs: b/564596647
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables two integration tests (testSimpleReadAndResume and testUniverseDomainWithMatchingDomain) in ITBigQueryStorageReadClientTest.java by removing their @Disabled annotations. Conversely, it disables the flaky testSimpleReadAndResume test in both v1beta1 and v1beta2 versions of ITBigQueryStorageTest.java by adding the @Disabled annotation. There are no review comments to evaluate, and I have no additional feedback to provide.
jinseopkim0
approved these changes
Nov 12, 2026
lqiu96
enabled auto-merge (squash)
November 12, 2026 17:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable testSimpleReadAndResume and testUniverseDomainWithMatchingDomain in v1.it.ITBigQueryStorageReadClientTest while disabling testSimpleReadAndResume in v1beta1 and v1beta2 ITBigQueryStorageTest so duplicate public-dataset CreateReadSession tests run on v1 only.
The assumption is that these test failures are due to the high load for the underlying CreateReadSession calls. Running this only for v1 and not v1beta1 and v1beta2 should help with the occasional INTERNAL errors. v1 is the public stable API and v1beta1 and v1beta2 are older version that are not actively developed on.
From b/564596647