[whowes]

WIP, not ready for review

[gemini-code-assist]

Code Review

This pull request introduces the ResumableUploadStallController class along with its unit tests to track chunk transfer progress against a minimum transfer rate and dynamically compute per-chunk and per-query retry deadlines. The review feedback focuses on improving robustness by adding input and state validation using Preconditions (such as validating non-null parameters, positive rates, and non-negative chunk sizes) and avoiding redundant exception wrapping in translateException when dealing with already-translated DeadlineExceededException instances.

[gemini-code-assist]

Validate that minimumRateMiBPerSec and stallTimeout are strictly positive, and that non-nullable parameters are not null. This prevents division by zero, negative durations, or NullPointerExceptions later in the execution.

  ResumableUploadStallController(
      ApiClock clock,
      double minimumRateMiBPerSec,
      Duration stallTimeout,
      @Nullable Duration globalDeadline,
      RetrySettings baseRetrySettings) {
    Preconditions.checkNotNull(clock, "clock cannot be null");
    Preconditions.checkNotNull(stallTimeout, "stallTimeout cannot be null");
    Preconditions.checkNotNull(baseRetrySettings, "baseRetrySettings cannot be null");
    Preconditions.checkArgument(minimumRateMiBPerSec > 0.0, "minimumRateMiBPerSec must be positive");
    Preconditions.checkArgument(!stallTimeout.isNegative() && !stallTimeout.isZero(), "stallTimeout must be positive");
    this.clock = clock;
    this.minimumRateBytesPerSec = minimumRateMiBPerSec * BYTES_PER_MIB;
    this.stallTimeout = stallTimeout;
    this.globalDeadline = globalDeadline;
    this.baseRetrySettings = baseRetrySettings;
  }

[gemini-code-assist]

Add state and argument validation to onChunkSuccess:

1. Ensure onChunkSuccess is not called before onStartChunk has initialized the chunk tracking state (i.e., currentChunkDeadline must not be null).
2. Ensure chunkBytes is non-negative.

Suggested change

	void onChunkSuccess(long chunkBytes) {
	void onChunkSuccess(long chunkBytes) {
	Preconditions.checkState(currentChunkDeadline != null, "onChunkSuccess called before onStartChunk");
	Preconditions.checkArgument(chunkBytes >= 0L, "chunkBytes must be non-negative");

[gemini-code-assist]

Import Preconditions to enable argument and state validation in the constructor and other methods.

Suggested change

	import com.google.common.base.MoreObjects;
	import com.google.common.base.MoreObjects;
	import com.google.common.base.Preconditions;

[gemini-code-assist]

Add a precondition check to ensure chunkBytes is non-negative. A negative value would indicate a bug in the caller and would corrupt the expected duration and lag calculations.

Suggested change

	RetrySettings onStartChunk(long chunkBytes) {
	RetrySettings onStartChunk(long chunkBytes) {
	Preconditions.checkArgument(chunkBytes >= 0L, "chunkBytes must be non-negative");

[gemini-code-assist]

Validate that recoveryBackoffDelay is non-null and non-negative to prevent invalid calculations.

Suggested change

	RetrySettings onStartQuery(Duration recoveryBackoffDelay) {
	RetrySettings onStartQuery(Duration recoveryBackoffDelay) {
	Preconditions.checkNotNull(recoveryBackoffDelay, "recoveryBackoffDelay cannot be null");
	Preconditions.checkArgument(!recoveryBackoffDelay.isNegative(), "recoveryBackoffDelay cannot be negative");

[gemini-code-assist]

If t is already a DeadlineExceededException thrown by this controller, calling translateException will wrap it again. Check if the exception is already a DeadlineExceededException created by this controller and return it directly to avoid redundant nesting.

Suggested change

	Throwable translateException(Throwable t, ResumableUploadCommand command) {
	Category category = ResumableUploadErrorClassifier.classify(t, command);
	if (category != Category.TRANSIENT && !(t instanceof DeadlineExceededException)) {
	return t;
	}
	return createStallOrGlobalTimeoutException(t);
	}
	Throwable translateException(Throwable t, ResumableUploadCommand command) {
	if (t instanceof DeadlineExceededException && t.getMessage() != null
	&& t.getMessage().startsWith("Resumable upload")) {
	return t;
	}
	Category category = ResumableUploadErrorClassifier.classify(t, command);
	if (category != Category.TRANSIENT && !(t instanceof DeadlineExceededException)) {
	return t;
	}
	return createStallOrGlobalTimeoutException(t);
	}

[sonarqubecloud]

Quality Gate passed for 'gapic-generator-java-root'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud