[rayudu3745]

Fixes #14967.

If the database's default_transaction_isolation holds a value that this client doesn't recognize, the PostgreSQL isolation level SHOW statements failed with FAILED_PRECONDITION. They now return the value that is stored in the database, so an older client keeps working with a database that uses a newer default isolation level.

Statement (database default unknown to the client, e.g. read committed)	Before	After
SHOW TRANSACTION ISOLATION LEVEL	FAILED_PRECONDITION	read committed
SHOW transaction_isolation	FAILED_PRECONDITION	read committed
SHOW default_transaction_isolation	FAILED_PRECONDITION	read committed

Changes

• DatabaseMetadata stores the default_transaction_isolation value as returned by Spanner, and derives the isolation level from it.
• New @InternalApi method DatabaseClient#getDatabaseDefaultIsolationLevelValue() returns that value.
• The SHOW statements return it when the isolation level is UNRECOGNIZED.

[gemini-code-assist]

Code Review

This pull request introduces a new method getDatabaseDefaultIsolationLevelValue() to DatabaseClient and its implementations to retrieve the raw string value of the default transaction isolation level. This allows handling unrecognized isolation levels (such as "read committed" in PostgreSQL) without throwing an exception. The feedback recommends adding @Nullable annotations to the overridden implementations of getDatabaseDefaultIsolationLevelValue() in DatabaseClientImpl and MultiplexedSessionDatabaseClient to match the interface definition. Additionally, it suggests wrapping the call to getDatabaseDefaultIsolationLevelValue() in ConnectionStatementExecutorImpl with Objects.requireNonNull to prevent potential null-safety warnings or runtime exceptions since the enclosing method returns a non-nullable string.

[olavloite]

Would it not be better to keep both these fields? That way, you do not need to reparse the string whenever the actual isolation level enum is needed. It would also make it possible to consider the string value more as a 'view' value, meaning that we could also format it in a more logical way. E.g. PostgreSQL normally returns isolation level names in lower case and without underscores.

[rayudu3745]

Done, the enum is parsed once and the string is kept as returned by Spanner.

[olavloite]

I think that you can simplify this method to something like this:

private String getEffectiveIsolationLevel(TransactionOptions.IsolationLevel isolationLevel) {
  if (isolationLevel != TransactionOptions.IsolationLevel.ISOLATION_LEVEL_UNSPECIFIED) {
    return formatIsolationLevel(isolationLevel);
  }
  String databaseDefault =
      getConnection().getDatabaseClient().getDatabaseDefaultIsolationLevelValue();
  if (databaseDefault != null) {
    return getConnection().getDialect() == Dialect.POSTGRESQL
        ? databaseDefault.toLowerCase(Locale.ROOT)
        : databaseDefault;
  }
  return formatIsolationLevel(TransactionOptions.IsolationLevel.SERIALIZABLE);
}

(and maybe even further if we keep both the string and enum values in DatabaseMetadata)

[rayudu3745]

Simplified as suggested. Spanner already stores these values in lower case with spaces, so the value is returned as-is.