Repository navigation
fix(bigquery-jdbc): prepare Arrow result set for job-stream data - #14941
Open
keshavdandeva wants to merge 2 commits into
Open
keshavdandeva wants to merge 2 commits into
keshavdandeva wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the BigQuery JDBC driver's Arrow result set processing to support streams with an unknown total row count, skip empty batches, and dynamically forward schemas. It also optimizes memory usage during Arrow batch deserialization by reading directly from the ByteString input stream instead of copying it to a heap byte array. Feedback is provided to wrap the newly introduced InputStream and ReadableByteChannel in a try-with-resources block to prevent potential static analysis warnings regarding unclosed resources.
logachev
reviewed
Nov 6, 2026
logachev
reviewed
Nov 6, 2026
logachev
approved these changes
Nov 13, 2026
keshavdandeva
force-pushed
the
fix/jdbc-arrow-resultset-hardening
branch
from
November 13, 2026 15:40
bb275f7 to
de89218
Compare
logachev
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/582676539
Prepares the Arrow reader for the job stream (b/581544197).
isBeforeFirst()/isLast()return false for an empty result.