chore: update googleapis commitish to 0fad501 - #14352
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates various dependency versions in the gapic-libraries-bom/pom.xml file and adds new API methods (CreateAuditSchedule, UpdateAuditSchedule, GetAuditSchedule, ListAuditSchedules) to the AuditManager service, including the necessary Java client and gRPC/HTTP-JSON stub implementations. The reviewer pointed out that using a -SNAPSHOT version for the parent POM in pom.xml is problematic for build stability and suggested reverting to a stable version.
| <artifactId>google-cloud-pom-parent</artifactId> | ||
| <groupId>com.google.cloud</groupId> | ||
| <version>1.91.0</version><!-- {x-version-update:google-cloud-pom-parent:current} --> | ||
| <version>1.92.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-pom-parent:current} --> |
There was a problem hiding this comment.
Using a -SNAPSHOT version for the parent POM google-cloud-pom-parent introduces build instability, as SNAPSHOT artifacts can change at any time. This can lead to non-reproducible builds, which is particularly problematic for a Bill of Materials (BOM) file that is meant to provide a stable set of dependencies. Please configure the automation to use a released version of the parent POM.
| <version>1.92.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-pom-parent:current} --> | |
| <version>1.91.0</version><!-- {x-version-update:google-cloud-pom-parent:current} --> |
References
- In Maven BOM files, do not update the parent POM version to match the BOM version if the project policy requires using released parent POMs.
| @@ -57,7 +57,6 @@ libraries: | |||
| - path: google/cloud/accessapproval/v1 | |||
| java: | |||
| api_description_override: enables controlling access to your organization's data by Google personnel. | |||
| released_version: 2.98.0 | |||
4 participants
Updated googleapis commitish in librarian.yaml to googleapis/googleapis@0fad501
💡 Note: If this PR is still open when the daily update workflow runs next, it will be closed and replaced with a new PR containing the latest updates.