Skip to content

feat(generator): introduce HttpJsonDescriptorComposer and add path prefix support - #14320

Draft
whowes wants to merge 2 commits into
whowes/generator-client-codegenfrom
whowes/generator-rest-composer-helpers
Draft

feat(generator): introduce HttpJsonDescriptorComposer and add path prefix support#14320
whowes wants to merge 2 commits into
whowes/generator-client-codegenfrom
whowes/generator-rest-composer-helpers

Conversation

@whowes

@whowes whowes commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Creates a new HttpJsonDescriptorComposer utility containing

  • existing shared REST AST decomposition utilities extracted from HttpJsonServiceStubClassComposer
  • new prependPathPrefix utility that allows a prefix (e.g. resumable/upload) to be prepended to HTTP path templates

New test class includes unit tests for both existing and new capabilities.

gemini-code-assist[bot]

This comment was marked as outdated.

@whowes
whowes added this pull request to stack #14327 September 9, 2026 06:35
@whowes
whowes force-pushed the whowes/generator-rest-composer-helpers branch from b85f89a to 459bd0c Compare September 9, 2026 15:50
@whowes
whowes force-pushed the whowes/generator-rest-composer-helpers branch from 459bd0c to 0da002b Compare September 9, 2026 20:16
@whowes
whowes removed this pull request from stack #14327 September 9, 2026 23:45
@whowes
whowes added this pull request to stack #14343 September 9, 2026 23:47
@whowes
whowes force-pushed the whowes/generator-rest-composer-helpers branch from 0da002b to 6917f74 Compare September 9, 2026 23:51
@whowes
whowes force-pushed the whowes/generator-rest-composer-helpers branch from 6917f74 to 2239313 Compare September 10, 2026 00:19
@whowes
whowes force-pushed the whowes/generator-rest-composer-helpers branch from 2239313 to 1b5a89d Compare September 10, 2026 01:15
@whowes
whowes force-pushed the whowes/generator-rest-composer-helpers branch from 1b5a89d to 24f4e9c Compare September 10, 2026 06:05
@whowes whowes changed the title feat(generator): expose REST composer helpers and add path prefix support feat(generator): introduce HttpJsonDescriptorComposer and add path prefix support Sep 11, 2026
@whowes
whowes force-pushed the whowes/generator-rest-composer-helpers branch from 24f4e9c to 29bb299 Compare September 11, 2026 17:23
@whowes
whowes removed this pull request from stack #14343 September 11, 2026 17:25
@whowes
whowes added this pull request to stack #14363 September 11, 2026 17:25
@whowes
whowes force-pushed the whowes/generator-rest-composer-helpers branch from 29bb299 to b139ed4 Compare September 11, 2026 18:30
@whowes
whowes force-pushed the whowes/generator-rest-composer-helpers branch from b139ed4 to ceef17a Compare September 11, 2026 20:00
@whowes
whowes force-pushed the whowes/generator-rest-composer-helpers branch from ceef17a to adf6d7c Compare September 11, 2026 21:13
@whowes
whowes force-pushed the whowes/generator-rest-composer-helpers branch from adf6d7c to 792c4ef Compare September 11, 2026 21:39
@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

…mable upload RPCs

- In AbstractServiceStubClassComposer: emit public ResumableUploadCallable<RequestT, ResponseT> [method]Callable() throwing UnsupportedOperationException
- In AbstractServiceClientClassComposer: emit public ResumableUploadCallable<RequestT, ResponseT> [method]Callable() delegating to stub
- In AbstractServiceClientClassComposer: emit synchronous convenience method [method](RequestT request, InputStream payload) calling ApiExceptions.callAndTranslateApiException
- Suppress method variants (flattened methods) for resumable upload RPCs
- In ServiceClientCommentComposer: emit Javadoc call context override warning on both callable method and synchronous convenience method
- Add unit test ResumableUploadServiceClientComposerTest verifying generated stub and client methods
…efix support

Extract shared REST ApiMethodDescriptor AST composition out of
HttpJsonServiceStubClassComposer into a dedicated HttpJsonDescriptorComposer
helper class, and add path prefix support to request formatters for resumable upload stubs.
@whowes
whowes force-pushed the whowes/generator-rest-composer-helpers branch from 792c4ef to 89b291e Compare September 11, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant