feat(bigquery-jdbc): add otel trace and span IDs to local logs - #13935
Open
keshavdandeva wants to merge 2 commits into
Open
feat(bigquery-jdbc): add otel trace and span IDs to local logs#13935keshavdandeva wants to merge 2 commits into
keshavdandeva wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request integrates OpenTelemetry tracing into the BigQuery JDBC driver's root logger, appending trace and span IDs to the log format when a valid span is active, and adds a unit test to verify this behavior. The review feedback suggests optimizing performance in the logging path by appending the trace block directly to the existing StringBuilder instead of creating intermediate concatenated strings.
keshavdandeva
marked this pull request as ready for review
July 28, 2026 21:35
logachev
approved these changes
Jul 29, 2026
| if (!spanContext.isValid()) { | ||
| return ""; | ||
| } | ||
| return "[trace_id=" |
Contributor
There was a problem hiding this comment.
nit: is returning StringBuilder that is being appended faster?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/538631816
This PR integrates OpenTelemetry tracing context into the JDBC driver's local file logging system, bringing it to parity with the existing Google Cloud Logging export integration.
Key Changes:
BigQueryJdbcRootLogger.java: Updated the root formatter to extract the activeTraceIdandSpanIdfrom the current OpenTelemetry thread context. When a valid trace is active, local logs will now automatically include a[trace_id=... span_id=...]block.BigQueryJdbcRootLoggerTest.java: AddedtestFormatterWithOpenTelemetrySpanto verify the formatter correctly extracts and formats IDs when a span is active.