Skip to content

ci(librarian): remove unused setup-python steps from workflows #13931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhumin8 merged 1 commit into from
Jul 28, 2026
+0 −9
Merged

ci(librarian): remove unused setup-python steps from workflows #13931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/librarian_generation_check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
run: |
echo "Error: Running this workflow manually on the main branch is not allowed."
exit 1
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4

Check warning on line 45 in .github/workflows/librarian_generation_check.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

ref-version-mismatch 

librarian_generation_check.yaml:45: action's hash pin has mismatched or missing version comment: points to commit 11d5960a3267
with:
fetch-depth: 0
persist-credentials: false
Expand All @@ -66,10 +66,6 @@
sudo apt-get update && sudo apt-get install -y maven
fi
mvn -version
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
with:
python-version: "3.12"
cache: 'pip'
- name: Run librarian install
run: |
librarian install
Expand Down Expand Up @@ -105,7 +101,7 @@
fi
- name: Create issue if previous step fails
if: ${{ failure() && github.event_name == 'push' && github.ref == 'refs/heads/main' }}
uses: googleapis/librarian/.github/actions/create-issue-on-failure@main # zizmor: ignore[unpinned-uses]

Check failure on line 104 in .github/workflows/librarian_generation_check.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

zizmor/unpinned-uses 

unpinned action reference: action is not pinned to a hash (required by blanket policy)
with:
title: "Librarian generate diff check failed on main branch"
body: |
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/update_librarian_googleapis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
working-directory: google-cloud-java
steps:
- name: Checkout google-cloud-java
uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6

Check warning on line 34 in .github/workflows/update_librarian_googleapis.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

ref-version-mismatch 

update_librarian_googleapis.yaml:34: action's hash pin has mismatched or missing version comment: points to commit d23441a48e51
with:
repository: googleapis/google-cloud-java
path: google-cloud-java
Expand Down Expand Up @@ -77,7 +77,7 @@
- name: Run librarian update & tidy
run: |
go run "github.com/googleapis/librarian/cmd/librarian@${STEPS_LIBRARIAN_OUTPUTS_VERSION}" update sources.googleapis
go run "github.com/googleapis/librarian/cmd/librarian@${{ steps.librarian.outputs.version }}" tidy

Check failure on line 80 in .github/workflows/update_librarian_googleapis.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

zizmor/template-injection 

code injection via template expansion: may expand into attacker-controllable code
env:
STEPS_LIBRARIAN_OUTPUTS_VERSION: ${{ steps.librarian.outputs.version }}
- name: Get latest commit
Expand Down Expand Up @@ -114,11 +114,6 @@
sudo apt-get update && sudo apt-get install -y maven
fi
mvn -version
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
if: steps.detect_librarian.outputs.has_changes == 'true'
with:
python-version: "3.12"
cache: 'pip'
- name: Run librarian install
if: steps.detect_librarian.outputs.has_changes == 'true'
run: |
Expand Down
Loading