test(showcase): add integration tests for exponential backoff retries using SequenceService - #13929
Open
nnicolee wants to merge 4 commits into
Open
test(showcase): add integration tests for exponential backoff retries using SequenceService#13929nnicolee wants to merge 4 commits into
nnicolee wants to merge 4 commits into
Conversation
… using SequenceService
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces integration tests for verifying exponential backoff retries on both gRPC and HTTP/JSON clients using the SequenceServiceClient. It also adds corresponding helper methods in TestClientInitializer to initialize these clients with custom retry settings. The feedback suggests simplifying the helper methods in TestClientInitializer by configuring SequenceServiceSettings.Builder directly, which avoids intermediate stub settings and unnecessary object allocations.
…est/showcase-retries
…rviceSettings.Builder directly
diegomarquezp
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds E2E retry integration tests verifying that client-side retry attempts adhere to the configured exponential backoff settings for both gRPC and HTTP/JSON transports.
Key Changes
TestClientInitializerfor creating theSequenceServiceClientconfigured with custom retry parameters and disabled jitter.SequenceServiceto record attempt timestamps on the server side, removing local CPU context-switching scheduling lag as a source of test flakiness.[UNAVAILABLE, UNAVAILABLE, UNAVAILABLE, OK]) and asserts that retry delays fall within the target exponential backoff timeline (with lenient safety margins).