Skip to content

deps: Update gRPC-Java to v1.82.2 - #13877

Open
lqiu96 wants to merge 8 commits into
mainfrom
update-grpc
Open

deps: Update gRPC-Java to v1.82.2#13877
lqiu96 wants to merge 8 commits into
mainfrom
update-grpc

Conversation

@lqiu96

@lqiu96 lqiu96 commented Jul 23, 2026

Copy link
Copy Markdown
Member

Result of running librarian generate --all.

This may also contain changes regenerated from googleapis proto changes. Might have been from the go run github.com/googleapis/librarian/cmd/librarian@${V} update sources.googleapis command while following the playbook, but was running into librarian generation issues so I follow the steps to setup librarian first.

Not sure how to "un-update the sources" from a local librarian install, but I don't think this generation should have an harm as it should have the updated sources.

@lqiu96
lqiu96 requested a review from blakeli0 July 23, 2026 17:05
@lqiu96
lqiu96 requested review from a team as code owners July 23, 2026 17:05

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gRPC dependency version (grpc.version) from 1.81.0 to 1.82.2 in the parent pom.xml file. There are no review comments, and I have no feedback to provide.

consistent across modules in this repository -->
<javax.annotation-api.version>1.3.2</javax.annotation-api.version>
<grpc.version>1.81.0</grpc.version>
<grpc.version>1.82.2</grpc.version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we upgrade gen code in the same PR?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lqiu96
lqiu96 requested a review from a team as a code owner July 23, 2026 22:17
Comment thread librarian.yaml
packaging: jar
- name: protoc-gen-java_grpc
version: 1.81.0
version: 1.82.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lqiu96
lqiu96 requested a review from a team as a code owner July 27, 2026 21:05
@snippet-bot

snippet-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 173 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the nightly generation PR has not been merged in 5 days. Let's wait until it is merged so the grpc version upgrade does not include any proto changes.
FYI, @zhumin8 was investigating the failures in recent PR, looks like we should be able to merge it tomorrow.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want this PR to only contain gRPC changes, then I don't think this version of generation will work.

I will need regenerate again since the protos have // Protobuf Java Version: 4.33.2 in them. The nightly generation should overwrite it to be correct versions, but that will also show up as diffs again even after the nightly generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants